Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and update struct stringer tests #3661

Merged
merged 27 commits into from
Oct 30, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 30, 2024

Blocker for #3660

Description

Actual change is in 247a13d

Also synced with master again.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

SupunS and others added 27 commits October 8, 2024 20:22
Enable type removal during contract updates
@SupunS SupunS self-assigned this Oct 30, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/string-templates commit 4f9e343
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member

Sorry for the extra hassle getting this in!

@SupunS SupunS merged commit 1210573 into feature/string-templates Oct 30, 2024
7 of 9 checks passed
@SupunS SupunS deleted the supun/refactor-tests branch October 30, 2024 20:06
@SupunS
Copy link
Member Author

SupunS commented Oct 30, 2024

no problem! It's just happened to be dependent on the order of PRs merged. I didn't realize it either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants